Re: [PATCH] revisions.txt: correct a mistake in dotted range notations section
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- May 2, 2023, 16:57 UTC
- Message-ID
- <64514101af396_1ba2d294cd@chronos.notmuch>
- In-Reply-To
- <CAPx1GverCci3SZQEMvFX_q7r3XSTKmPizfcj8QcvGNud7reY9g@mail.gmail.com>
Chris Torek wrote:
Show 12 quoted lines
> On Wed, Apr 26, 2023 at 1:00 AM Pooyan Khanjankhani via GitGitGadget > <gitgitgadget@gmail.com> wrote: > > From: Pooyan Khanjankhani <p.khanjankhani@digikala.com> > > > > Insert a missing 'not' word in a negative sentence. > > ... but are [not] reachable from neither A or C. > > There's a peculiarity of the English language here that means you > should not use the word "not". The actual error is using "or" as > the conjunction, instead of "nor": the construct should read > "neither <alternative 1> nor <alternative 2>", and it means that > both alternatives are rejected.
But it's not the same to say "not reachable from either A or C", and "reachable from neither A nor C". In the latter if a commit is reachable from X (or anything other than A or C), it should be included.
So A~ would be included, because it's reachable from B and reachable from not A (i.e. B).
It should be "not reachable from either A or C".
Cheers.
-- Felipe Contreras