Re: [PATCH 1/2] factor out strbuf_expand_bad_format()

From: Chris Torek <chris.torek@gmail.com>
Date: Mar 24, 2024, 09:00 UTC
Message-ID: <CAPx1GveKUL1nexRQDYueAVU7G0vp+JzB=5yUf4r4eoRjU49Jcg@mail.gmail.com>
In-Reply-To: <27cdcde7-74bc-4ee8-bc84-9a6046292cae@web.de>

Minor:

On Sun, Mar 24, 2024 at 1:00 AM René Scharfe <l.s.r@web.de> wrote:

Show 7 quoted lines

> @@ -308,8 +301,7 @@ static void show_ce_fmt(struct repository *repo, const struct cache_entry *ce,
>                 else if (skip_prefix(format, "(path)", &format))
>                         write_name_to_buf(&sb, fullname);
>                 else
> -                       die(_("bad ls-files format: %%%.*s"),
> -                           (int)(end - format + 1), format);
> +                       strbuf_expand_bad_format(format, "ls-format");

This last string constant is clearly supposed to be "ls-files".

Chris