Re: [PATCH 1/2] factor out strbuf_expand_bad_format()

From: René Scharfe <l.s.r@web.de>
Date: Mar 24, 2024, 11:17 UTC
Message-ID: <67aa076b-1a73-45a6-b727-6416963a1bd0@web.de>
In-Reply-To: <CAPx1GveKUL1nexRQDYueAVU7G0vp+JzB=5yUf4r4eoRjU49Jcg@mail.gmail.com>

Am 24.03.24 um 10:00 schrieb Chris Torek:

Show 12 quoted lines

> Minor:
>
> On Sun, Mar 24, 2024 at 1:00 AM René Scharfe <l.s.r@web.de> wrote:
>> @@ -308,8 +301,7 @@ static void show_ce_fmt(struct repository *repo, const struct cache_entry *ce,
>>                 else if (skip_prefix(format, "(path)", &format))
>>                         write_name_to_buf(&sb, fullname);
>>                 else
>> -                       die(_("bad ls-files format: %%%.*s"),
>> -                           (int)(end - format + 1), format);
>> +                       strbuf_expand_bad_format(format, "ls-format");
>
> This last string constant is clearly supposed to be "ls-files".

LOL.  Seems I can only hold one f-word in my mind at a time.

Thank you for catching this!

René