git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] combine-diff: handle --find-object in multitree code path

From
Chris Torek <chris.torek@gmail.com>
Date
Sep 30, 2020, 20:06 UTC
Message-ID
<CAPx1Gvd7WpAgUGgZkZARY7JcFj8nbDJ6zEDTSaBt2=xR535E-g@mail.gmail.com>
In-Reply-To
<20200930115240.GA1899467@coredump.intra.peff.net>
On Wed, Sep 30, 2020 at 4:54 AM Jeff King <peff@peff.net> wrote:
Show 8 quoted lines
> I'm a little nervous that the second "wart" may actually be making
> things worse, because now we sometimes produce a wrong answer and
> sometime a right one, and it can be difficult to know which options
> cause which (e.g., rename detection puts us onto the slow path). Is it
> worse to sometimes be right and sometimes wrong, or to always be
> consistently and predictably wrong? I suppose one could even argue that
> the current semantics aren't "wrong", but just what we happen to
> produce. But IMHO they are so un-useful as to be considered wrong.

"Predictably wrong" *is* actually useful while "unpredictably wrong" is, um, "less useful". Perhaps just documenting exactly which options use which path? Basically turn some of this into documentation.

Chris
Previous: Jeff KingNext: Jeff King
Message 2 of 5 in “combine-diff: handle --find-object in multitree code path”
  1. combine-diff: handle --find-object in multitree code pathJeff King, Sep 30, 2020
  2. Chris TorekSep 30, 2020
  3. Jeff KingSep 30, 2020
  4. Junio C HamanoSep 30, 2020
  5. Jeff KingSep 30, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.