From: Chris Torek <chris.torek@gmail.com>
Date: Wed, 30 Sep 2020 20:06:02 GMT
Subject: Re: [PATCH] combine-diff: handle --find-object in multitree code path
Message-ID: <CAPx1Gvd7WpAgUGgZkZARY7JcFj8nbDJ6zEDTSaBt2=xR535E-g@mail.gmail.com>
In-Reply-To: <20200930115240.GA1899467@coredump.intra.peff.net>

On Wed, Sep 30, 2020 at 4:54 AM Jeff King <peff@peff.net> wrote:
> I'm a little nervous that the second "wart" may actually be making
> things worse, because now we sometimes produce a wrong answer and
> sometime a right one, and it can be difficult to know which options
> cause which (e.g., rename detection puts us onto the slow path). Is it
> worse to sometimes be right and sometimes wrong, or to always be
> consistently and predictably wrong? I suppose one could even argue that
> the current semantics aren't "wrong", but just what we happen to
> produce. But IMHO they are so un-useful as to be considered wrong.

"Predictably wrong" *is* actually useful while "unpredictably wrong"
is, um, "less useful".  Perhaps just documenting exactly which options
use which path?  Basically turn some of this into documentation.

Chris