git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] builtin/help.c: move strbuf out of help loops

From
Amisha Chhajed <amishhhaaaa@gmail.com>
Date
Mar 11, 2026, 19:30 UTC
Message-ID
<CAPvEtrd9Yri5LQu9DiMAO4EDquyd-JxwNBGn+h=+=E+oKJ2ERw@mail.gmail.com>
In-Reply-To
<CAGWgyh_dJX7TteKjwVXUwnmUL5kmZifpA0a4n1RiwRvCBEY5gw@mail.gmail.com>
Show 7 quoted lines
> After looking at the refactor of list_config_help() in the
> other active thread, I agree that my optimization is no longer
> necessary.
>
> Amisha's new structure with set_config_vars() and set_config_sections()
> is much cleaner. Since the logic is now encapsulated in these helpers,
> my proposed changes would not be applicable.

I feel removing out the strbuf initialisation and release out of the loop is still applicable, I have added all the parts in v5 which were not fixed by my improvements and tagged you, check it out here https://lore.kernel.org/git/20260311192151.60489-1-amishhhaaaa@gmail.com/

-- 
Thanks,
Amisha
Previous: Siddharth ShrimaliNext: Junio C Hamano
Message 6 of 7 in “builtin/help.c: move strbuf out of help loops”
  1. builtin/help.c: move strbuf out of help loopsSiddharth Shrimali, Mar 10, 2026
  2. Patrick SteinhardtMar 10, 2026
  3. builtin/help.c: move strbuf out of help loopsSiddharth Shrimali, Mar 10, 2026
  4. Junio C HamanoMar 10, 2026
  5. Siddharth ShrimaliMar 11, 2026
  6. Amisha ChhajedMar 11, 2026
  7. Junio C HamanoMar 11, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.