Re: [PATCH v2] builtin/help.c: move strbuf out of help loops

From: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>
Date: Mar 11, 2026, 18:13 UTC
Message-ID: <CAGWgyh_dJX7TteKjwVXUwnmUL5kmZifpA0a4n1RiwRvCBEY5gw@mail.gmail.com>
In-Reply-To: <xmqq1phrtoen.fsf@gitster.g>

On Wed, 11 Mar 2026 at 02:03, Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

> Having looked at this patch, I recall somebody else is revamping
> this function already, so this patch would step on their toes.
> Please pay attention to what is going on in the project around the
> code you are touching, and coordinate with others who are working on
> the same code if necessary.
>
> https://lore.kernel.org/git/20260228104654.80831-2-amishhhaaaa@gmail.com/
>
> Thanks.

Hi Junio (CC'ing Amisha),

After looking at the refactor of list_config_help() in the other active thread, I agree that my optimization is no longer necessary.

Amisha's new structure with set_config_vars() and set_config_sections() is much cleaner. Since the logic is now encapsulated in these helpers, my proposed changes would not be applicable.

I'll drop this patch and focus on my other contributions. Thanks for the guidance!

Regards, Siddharth