Re: Test t2028 failes

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 3, 2018, 08:45 UTC
Message-ID: <CAPig+cTvVwLDW+6rHNZbUwWwYUGBRioA6B+jM832JpUYAoPVWw@mail.gmail.com>
In-Reply-To: <0156c688-2c81-1de8-f550-efb517b7707d@frm2.tum.de>

On Tue, Apr 3, 2018 at 4:38 AM, Jens Krüger <Jens.Krueger@frm2.tum.de> wrote:

Show 21 quoted lines

> Am 03.04.2018 um 10:16 schrieb Eric Sunshine:
>> Using the "out" file you attached, can you show the output of these
>> commands?
>>      grep "^worktree.*/destination" out
>>      echo $?
>>      grep "^worktree.*/source" out
>>      echo $?
>> I'd expect the first $? to report 0 and the second 1 in a working
>> installation.
>
> Both of them return 0, but I guess I found the problem. The second
> 'grep' call returned the following output:
>
> worktree /home/jkrueger/sources/git/t/trash directory.t2028-worktree-move
> worktree /home/jkrueger/sources/git/t/trash
> directory.t2028-worktree-move/elsewhere
> worktree /home/jkrueger/sources/git/t/trash
> directory.t2028-worktree-move/some-dir/destination
>
> If I move my checkout into another directory not containing 'source' in
> the path it will work.

Okay, thanks for diagnosing the problem. We can fix the test by tightening the regex to also anchor with '$' so that it won't be fooled like that.