git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Test t2028 failes

From
JKJens Krüger <jens.krueger@frm2.tum.de>
Date
Apr 3, 2018, 08:42 UTC
Message-ID
<6d28dbb1-0c4c-6fca-555c-afb6c1c9e781@frm2.tum.de>
In-Reply-To
<CAPig+cSsTPKoLfcxrgD4+NhXa5AeWynxumo8Zed_PH-q3U163w@mail.gmail.com>
Am 03.04.2018 um 10:16 schrieb Eric Sunshine:
Show 19 quoted lines
> On Tue, Apr 3, 2018 at 4:01 AM, Jens Krüger <Jens.Krueger@frm2.tum.de> wrote:
>> The actual2 file does not exists, if I call the ./t2028-worktree-move.sh
>> with the '-v -i' options, only without any option or with '-v' option.
> 
> The content of the various files looks correct, and absence of
> "actual2" implies that one of the grep's failed, which is very odd
> considering that "out" has the expected content.
> 
> Using the "out" file you attached, can you show the output of these commands?
> 
>      grep "^worktree.*/destination" out
>      echo $?
>      grep "^worktree.*/source" out
>      echo $?
> 
> I'd expect the first $? to report 0 and the second 1 in a working installation.
> 
> Also, are you using an unusual 'grep'? What does "command -v grep" report?
> 
Maybe, the attached patch may help. On my machine(s) it helped.
diff --git a/t/t2028-worktree-move.sh b/t/t2028-worktree-move.sh
index 5d5b3632ba..65c7311865 100755
--- a/t/t2028-worktree-move.sh
+++ b/t/t2028-worktree-move.sh
@@ -77,7 +77,7 @@ test_expect_success 'move worktree' '
 	test_path_is_missing source &&
 	git worktree list --porcelain >out &&
 	grep "^worktree.*/destination" out &&
-	! grep "^worktree.*/source" out &&
+	! grep "^worktree.*/source$" out &&
 	git -C destination log --format=%s >actual2 &&
 	echo init >expected2 &&
 	test_cmp expected2 actual2
Previous: Eric SunshineNext: Eric Sunshine
Message 7 of 9 in “Test t2028 failes”
  1. Jens KrügerApr 3, 2018
  2. Eric SunshineApr 3, 2018
  3. Jens KrügerApr 3, 2018
  4. Eric SunshineApr 3, 2018
  5. Jens KrügerApr 3, 2018
  6. Eric SunshineApr 3, 2018
  7. Jens KrügerApr 3, 2018
  8. Eric SunshineApr 3, 2018
  9. Jens KrügerApr 3, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.