git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 4/4] cache-tree: Write updated cache-tree after commit

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jul 13, 2014, 18:58 UTC
Message-ID
<CAPig+cTqd8LMMA+MsSiuxnyXy+pYDj57UdVmYHNnvW5NBG8W0Q@mail.gmail.com>
In-Reply-To
<xmqqbnst18dh.fsf@gitster.dls.corp.google.com>
On Sun, Jul 13, 2014 at 1:22 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 17 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes:
>
>>> +       (echo p; echo 1; echo; echo s; echo n; echo y; echo q) | git commit --interactive -m foo
>>
>> Broken &&-chain.
>>
>> Would a printf make this more readable?
>>
>>     printf "p\n1\n\ns\nn\ny\nq\n" | git commt ... &&
>>
>> Perhaps not.
>
> But
>
>         printf "%s\n" p 1 "" s n y q
>
> is vastly more readable, I would think.

Yes, that's much nicer (and I should have thought of it myself considering that I made effectively the same suggestion elsewhere [1]).

> Don't we have test_write_lines which is exactly that, though?
Indeed, that's even better.
[1]: http://thread.gmane.org/gmane.comp.version-control.git/233260/focus=234499
Previous: Junio C Hamano
Message 7 of 7 in “cache-tree: Create/update cache-tree on checkout”
  1. 1/4 cache-tree: Create/update cache-tree on checkoutDavid Turner, Jul 11, 2014
  2. 2/4 test-dump-cache-tree: invalid trees are not errorsDavid Turner, Jul 11, 2014
  3. 3/4 cache-tree: subdirectory testsDavid Turner, Jul 11, 2014
  4. 4/4 cache-tree: Write updated cache-tree after commitDavid Turner, Jul 11, 2014
  5. Eric SunshineJul 11, 2014
  6. Junio C HamanoJul 13, 2014
  7. Eric SunshineJul 13, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.