From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 13 Jul 2014 18:58:20 GMT
Subject: Re: [PATCH v7 4/4] cache-tree: Write updated cache-tree after commit
Message-ID: <CAPig+cTqd8LMMA+MsSiuxnyXy+pYDj57UdVmYHNnvW5NBG8W0Q@mail.gmail.com>
In-Reply-To: <xmqqbnst18dh.fsf@gitster.dls.corp.google.com>

On Sun, Jul 13, 2014 at 1:22 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
>
>>> +       (echo p; echo 1; echo; echo s; echo n; echo y; echo q) | git commit --interactive -m foo
>>
>> Broken &&-chain.
>>
>> Would a printf make this more readable?
>>
>>     printf "p\n1\n\ns\nn\ny\nq\n" | git commt ... &&
>>
>> Perhaps not.
>
> But
>
>         printf "%s\n" p 1 "" s n y q
>
> is vastly more readable, I would think.

Yes, that's much nicer (and I should have thought of it myself
considering that I made effectively the same suggestion elsewhere
[1]).

> Don't we have test_write_lines which is exactly that, though?

Indeed, that's even better.

[1]: http://thread.gmane.org/gmane.comp.version-control.git/233260/focus=234499