Re: [REGRESSION] gitk can't be run from non-worktree folders

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 23, 2020, 16:36 UTC
Message-ID: <CAPig+cTixT9JYDPn-umKdQLtTm5byA1wwmvVY1ryuh+hv2=6MQ@mail.gmail.com>
In-Reply-To: <20200123163151.GC6837@szeder.dev>

[cc:+peff]

On Thu, Jan 23, 2020 at 11:32 AM SZEDER Gábor <szeder.dev@gmail.com> wrote:

Show 14 quoted lines

> On Thu, Jan 23, 2020 at 05:04:09PM +0100, ch wrote:
> > I recently updated my Git installation from 2.24.1.windows.2 to
> > 2.25.0.windows.1 and from the looks of it the included version of gitk does not
> > support being run from non-worktree folders of a repository anymore (like the
> > .git folder for example).
> I've stumbled upon the same issue when I tried to run 'gitk' in a bare
> repository a while ago, but it refused to run with the same error
> message.
>
> Are you sure it's a recent regression?  I have no experience with
> 'gitk' in Git for Windows, but on Linux this has been broken for quite
> some time, namely since 784b7e2f25 (gitk: Fix "External diff" with
> separate work tree, 2011-04-04) in the v1.7 era.  FWIW, reverting that
> commit on top of v2.25.0 makes 'gitk' work again in bare repositories.

It's a new regression introduced by 2d92ab32fd (rev-parse: make --show-toplevel without a worktree an error, 2019-11-19), as far as I can tell. I have many times used gitk on bare repositories as an interactive replacement for git-log, so this is a unfortunate bit of fallout from that change. That's not to say that 2d92ab32fd should be reverted, though... perhaps gitk itself needs a bit of a fix.