git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: to run in a bare repository (was: gitk can't be run from non-worktree folders)

From
Jeff King <peff@peff.net>
Date
Jan 23, 2020, 19:27 UTC
Message-ID
<20200123192707.GA110440@coredump.intra.peff.net>
In-Reply-To
<xmqqk15i3rp7.fsf_-_@gitster-ct.c.googlers.com>
On Thu, Jan 23, 2020 at 11:20:36AM -0800, Junio C Hamano wrote:
> -- >8 --
> Subject: [PATCH] gitk: be prepared to be run in a bare repository

Thanks all for cleaning up the mess I caused. I do prefer adjusting gitk like this rather than reverting the change in Git. Despite the regression, I think the case of "--show-toplevel without a working tree" is sufficiently undefined that it's probably good for callers to actually decide what the right behavior is.

> Recent versions of git however notices that "rev-parse --show-toplevel"
> executed in a bare repository is an error, which makes gitk stop,
> even before the user could attempt to run external diff.

It might be worth mentioning 2d92ab32 by name in this paragraph of the commit message.

-Peff
Previous: Eric SunshineNext: ch
Message 9 of 15 in “[REGRESSION] gitk can't be run from non-worktree folders”
  1. chJan 23, 2020
  2. SZEDER GáborJan 23, 2020
  3. Eric SunshineJan 23, 2020
  4. SZEDER GáborJan 23, 2020
  5. SZEDER GáborJan 23, 2020
  6. Junio C HamanoJan 23, 2020
  7. gitk: to run in a bare repository (was: gitk can't be run from non-worktree folders)Junio C Hamano, Jan 23, 2020
  8. Eric SunshineJan 23, 2020
  9. Jeff KingJan 23, 2020
  10. chMar 30, 2020
  11. Eric SunshineOct 11, 2020
  12. chOct 13, 2020
  13. Pratyush YadavOct 13, 2020
  14. chApr 2, 2020
  15. Junio C HamanoApr 2, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.