Re: [PATCH v3 5/7] completion: get rid of compgen

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 10, 2013, 10:10 UTC
Message-ID: <CAPig+cThNDvHWMq3h1Kh2QKNew0kqbXrfxcS05jrBh+rCLghzA@mail.gmail.com>
In-Reply-To: <1365577077-12648-6-git-send-email-felipe.contreras@gmail.com>

On Wed, Apr 10, 2013 at 2:57 AM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

> The functionality we use from compgen is not much, we can do the same
> manually, with drastical improvements in speed, specially when dealing

s/drastical/drastic/ s/specially/especially/

> with only a few words.
>
> This patch also has the sideffect that brekage reported by Jeroen Meijer

s/sideffect/side effect/ s/brekage/breakage/

Show 7 quoted lines

> and SZEDER Gábor gets fixed because we no longer expand the resulting
> words.
>
> So, unless 'git checkout <tab>' usually gives you more than 100000
> results, you'll get an improvement :)
>
> Other possible solutions perform better after 1000 words, but worst if

s/worst/worse/

Show 8 quoted lines

> less than that:
>
>   COMPREPLY=($(awk -v cur="$3" -v pre="$2" -v suf="$4"
>         '$0 ~ cur { print pre$0suf }' <<< "$1" ))
>
>   COMPREPLY=($(printf -- "$2%s$4\n" $1 | grep "^$2$3"))
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>