git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 6/7] completion: get rid of __gitcomp_1

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Apr 10, 2013, 10:13 UTC
Message-ID
<CAPig+cR4_ZB=s8JVT2LRJGcNhM9ZaESWZQ5v6Wa20=bWGoMydg@mail.gmail.com>
In-Reply-To
<1365577077-12648-7-git-send-email-felipe.contreras@gmail.com>

On Wed, Apr 10, 2013 at 2:57 AM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

> There's no point in calling a separate function that is only used in one
> place. Specially considering that there's no need to call compgen, and
s/Specially/Especially/
> we traverse the words ourselves both in __gitcompadd, and __gitcomp_1.
s/ourselves/ourself/
> So lets squash the functions together, and traverse only once.
s/lets/let's/
Show 24 quoted lines
> This improves performance. For N number of words:
>
>   == 1 ==
>   original: 0.002s
>   new: 0.000s
>   == 10 ==
>   original: 0.005s
>   new: 0.001s
>   == 100 ==
>   original: 0.009s
>   new: 0.006s
>   == 1000 ==
>   original: 0.027s
>   new: 0.019s
>   == 10000 ==
>   original: 0.163s
>   new: 0.151s
>   == 100000 ==
>   original: 1.555s
>   new: 1.497s
>
> No functional changes.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Previous: Felipe ContrerasNext: John Keeping
Message 16 of 20 in “completion: reorg and performance improvements”
  1. 0/7 completion: reorg and performance improvementsFelipe Contreras, Apr 10, 2013
  2. 1/7 completion: trivial test improvementFelipe Contreras, Apr 10, 2013
  3. 2/7 completion: get rid of empty COMPREPLY assignmentsFelipe Contreras, Apr 10, 2013
  4. Eric SunshineApr 10, 2013
  5. 3/7 completion: add new __gitcompadd helperFelipe Contreras, Apr 10, 2013
  6. Junio C HamanoApr 12, 2013
  7. Felipe ContrerasApr 12, 2013
  8. Junio C HamanoApr 12, 2013
  9. 4/7 completion: add __gitcomp_nl testsFelipe Contreras, Apr 10, 2013
  10. 5/7 completion: get rid of compgenFelipe Contreras, Apr 10, 2013
  11. Eric SunshineApr 10, 2013
  12. Felipe ContrerasApr 10, 2013
  13. John KeepingApr 10, 2013
  14. Junio C HamanoApr 12, 2013
  15. 6/7 completion: get rid of __gitcomp_1Felipe Contreras, Apr 10, 2013
  16. Eric SunshineApr 10, 2013
  17. John KeepingApr 10, 2013
  18. Eric SunshineApr 10, 2013
  19. 7/7 completion: small optimizationFelipe Contreras, Apr 10, 2013
  20. Junio C HamanoApr 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.