Re: [PATCH] gc: remove trailing dot from "gc.log" line

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 31, 2021, 18:23 UTC
Message-ID: <CAPig+cTaJ=xm=K5Y8yn8RiOFHBH-nzhRztYRz3kYsqsyJUTACg@mail.gmail.com>
In-Reply-To: <xmqqpmtttr56.fsf@gitster.g>

On Tue, Aug 31, 2021 at 2:18 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 20 quoted lines

> Eric Sunshine <sunshine@sunshineco.com> writes:
> > On Tue, Aug 31, 2021 at 10:37 AM Ævar Arnfjörð Bjarmason
> > <avarab@gmail.com> wrote:
> >>                 warning(_("The last gc run reported the following. "
> >>                                "Please correct the root cause\n"
> >> -                              "and remove %s.\n"
> >> +                              "and remove %s\n"
> >
> > Even more bikeshedding:
> >
> >     Please correct the root cause and remove
> >     /path/to/repo/.git/gc.log
> >     to allow automatic cleanup to resume.
> >
> > or something.
>
> I also found the line break before "and remove" strange, but I think
> that is because the "Please" is not at the beginning of the
> paragraph, but is a second sentence.  Perhaps unfolding "and remove"
> would make the first line overly long?

Yep, you're right, and perhaps my "Even more bikeshedding" didn't clearly indicate that I was bikeshedding more about combining the "Please correct..." and "Automatic cleanup..." sentences into a single sentence, both as a another way to deal with the punctuation issue (thus allowing easy double-click) and to make the whole thing read a bit better.