Re: git-gui: Visualize * History does nothing on macOS

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 21, 2024, 04:35 UTC
Message-ID: <CAPig+cTaBxoJbsVsZLYLZueZpSkmt2zRJzgE=HOO30FvxpUUnA@mail.gmail.com>
In-Reply-To: <41408b88-2938-4112-a02c-53876e20f5b1@haller-berlin.de>

On Thu, Jun 20, 2024 at 10:40 AM Stefan Haller <lists@haller-berlin.de> wrote:

Show 12 quoted lines

> On 09.05.24 21:05, Eric Sunshine wrote:
> > A patch to fix this problem in `gitk` was posted[1] in 2018 but never
> > got picked up since the `gitk` maintainer seems to have disappeared.
> > Considering that the patch is still relevant, perhaps it might make
> > sense for Junio to pick it up himself and apply it to the Git tree(?).
> >
> > [1]: https://lore.kernel.org/git/20180724065120.7664-1-sunshine@sunshineco.com/
>
> Whether the patch is still relevant depends on which versions of Tcl/Tk
> we are supporting. On recent versions, the whole AppleScript business is
> no longer necessary, windows come to the front correctly without it. So
> a better patch might be to remove the osascript call entirely.

That's a possibility, though it abandons users stuck on older systems (which may not be a big deal since it's only a minor annoyance if the Gitk window doesn't come to the foreground).

Unfortunately, it seems unlikely that either my 2018 patch or your suggestion will be applied since the Gitk maintainer seems to have disappeared(?)[*].

[*] Interestingly, I just checked git://ozlabs.org/~paulus/gitk and noticed that changes were applied as recently as 2022-02-20, however, the patch I submitted was not one of them.