Re: git-gui: Visualize * History does nothing on macOS

From: Stefan Haller <lists@haller-berlin.de>
Date: Jun 20, 2024, 14:40 UTC
Message-ID: <41408b88-2938-4112-a02c-53876e20f5b1@haller-berlin.de>
In-Reply-To: <CAPig+cS1o5bqK2Ph1fFt2wi6QaOO2=83xwoqoTLifA6z3NssXA@mail.gmail.com>

On 09.05.24 21:05, Eric Sunshine wrote:

Show 6 quoted lines

> A patch to fix this problem in `gitk` was posted[1] in 2018 but never
> got picked up since the `gitk` maintainer seems to have disappeared.
> Considering that the patch is still relevant, perhaps it might make
> sense for Junio to pick it up himself and apply it to the Git tree(?).
> 
> [1]: https://lore.kernel.org/git/20180724065120.7664-1-sunshine@sunshineco.com/

Whether the patch is still relevant depends on which versions of Tcl/Tk we are supporting. On recent versions, the whole AppleScript business is no longer necessary, windows come to the front correctly without it. So a better patch might be to remove the osascript call entirely.

In my locally patched version of gitk I did that long ago. I don't remember which version of Tcl/Tk I was running back then, but my patch that removes the code is from October 2020.

-Stefan