Re: [PATCH v5] use starts_with() instead of !memcmp()

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 19, 2014, 04:13 UTC
Message-ID: <CAPig+cTWV0PWOh88u+rbMPvnn3O+OhTJATEtXXi4oLKUN25Ezw@mail.gmail.com>
In-Reply-To: <1395191883-42409-1-git-send-email-quintus.public@gmail.com>

On Tue, Mar 18, 2014 at 9:18 PM, Quint Guvernator <quintus.public@gmail.com> wrote:

> Another version, this time very in line with the review and commentary of
> Junio, Eric, and Michael.  This version boasts a revamped commit message and
> fewer but surer hunks changed.

Explaining what changed in this version is indeed a courtesy to reviewers. Thanks.

For bonus points, provide a link to the previous attempt, like this [1].

[1]: http://thread.gmane.org/gmane.comp.version-control.git/244292

Show 16 quoted lines

> Thanks again for the guidance.
>
> Quint Guvernator (1):
>   use starts_with() instead of !memcmp()
>
>  builtin/apply.c        |  4 ++--
>  builtin/for-each-ref.c |  2 +-
>  builtin/mktag.c        |  2 +-
>  builtin/patch-id.c     | 10 +++++-----
>  connect.c              |  4 ++--
>  imap-send.c            |  6 +++---
>  remote.c               |  2 +-
>  7 files changed, 15 insertions(+), 15 deletions(-)
>
> --
> 1.9.0