Re: [PATCH v5] use starts_with() instead of !memcmp()

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 21, 2014, 18:05 UTC
Message-ID: <CAPig+cQeVYhndNEmiKFVxfGv=p2vZWmoP_nwwc+NTPLGQfbeng@mail.gmail.com>
In-Reply-To: <xmqqzjkjv6gx.fsf@gitster.dls.corp.google.com>

On Fri, Mar 21, 2014 at 12:53 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Eric Sunshine <sunshine@sunshineco.com> writes:
>
>> On Tue, Mar 18, 2014 at 9:18 PM, Quint Guvernator
>> <quintus.public@gmail.com> wrote:
>>> Another version, this time very in line with the review and commentary of
>>> Junio, Eric, and Michael.  This version boasts a revamped commit message and
>>> fewer but surer hunks changed.
>>
>> Explaining what changed in this version is indeed a courtesy to
>> reviewers. Thanks.
>
> So, is that a "reviewed-by: Eric"?

No, sorry. You and Peff were actively reviewing Quint's submissions, so I merely scanned them quickly without making a careful examination. I've been commenting upon so many GSoC submissions that it's hard to remember which is which, and upon reading "Another version, this time very in line with the review and commentary Junio, Eric, and Michael", I had to search the list archive to figure out why my name was listed. Hence, the suggestion from me that providing a link to the previous attempt is a welcome courtesy.