git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] t6025: modernize style

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jan 17, 2020, 21:15 UTC
Message-ID
<CAPig+cTW4hATiMYVE7kzcLqK3do9=K8X0nmYjWLOhabgOxZ-XA@mail.gmail.com>
In-Reply-To
<20200117204426.9347-2-shouryashukla.oo@gmail.com>

On Fri, Jan 17, 2020 at 3:45 PM Shourya Shukla <shouryashukla.oo@gmail.com> wrote:

> [PATCH 1/3] t6025: modernize style

When sending a new version of a patch series, indicate this via "[PATCH v2 1/3]", for instance. The -v option of "git format-patch" can help automate this for you.

Show 19 quoted lines
> The tests in `t6025-merge-symlinks.sh` were written a long time ago, and
> has a lot of style violations, including the mixed-use of tabs and spaces,
> missing indentations, and other shell script style violations. Update it to
> match the CodingGuidelines.
>
> Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>
> ---
> diff --git a/t/t6025-merge-symlinks.sh b/t/t6025-merge-symlinks.sh
> @@ -10,52 +10,55 @@ if core.symlinks is false.'
> +test_expect_success 'setup' '
> +       git config core.symlinks false &&
> +       >file &&
> +       git add file &&
> +       git commit -m initial &&
> +       git branch b-symlink &&
> +       git branch b-file &&
> +       l=$(printf file | git hash-object -t blob -w --stdin) &&
> +       echo "120000 $l symlink" |
> +       git update-index --index-info &&
As mentioned[1] in the review of v1, this should be written:
    echo "120000 $l symlink" | git update-index --index-info &&
[1]: https://lore.kernel.org/git/xmqqftgff1r0.fsf@gitster-ct.c.googlers.com/
Show 11 quoted lines
> +       git commit -m master &&
> +       git checkout b-symlink &&
> +       l=$(printf file-different | git hash-object -t blob -w --stdin) &&
> +       echo "120000 $l symlink" |
> +       git update-index --index-info &&
> +       git commit -m b-symlink &&
> +       git checkout b-file &&
> +       echo plain-file >symlink &&
> +       git add symlink &&
> +       git commit -m b-file
> +'
Previous: Shourya ShuklaNext: Junio C Hamano
Message 10 of 24 in “t6025: updating tests”
  1. 0/3 t6025: updating testsShourya Shukla, Jan 16, 2020
  2. 1/3 t6025: modernize styleShourya Shukla, Jan 16, 2020
  3. Johannes SchindelinJan 16, 2020
  4. 2/3 t6025: replace pipe with redirection operatorShourya Shukla, Jan 16, 2020
  5. Junio C HamanoJan 16, 2020
  6. 3/3 t6025: use helpers to replace test -f <path>Shourya Shukla, Jan 16, 2020
  7. Junio C HamanoJan 16, 2020
  8. 0/3 t6025: amended changes after suggestions from the communityShourya Shukla, Jan 17, 2020
  9. 1/3 t6025: modernize styleShourya Shukla, Jan 17, 2020
  10. Eric SunshineJan 17, 2020
  11. Junio C HamanoJan 17, 2020
  12. 2/3 t6025: replace pipe with redirection operatorShourya Shukla, Jan 17, 2020
  13. Eric SunshineJan 17, 2020
  14. 0/3 t6025: updating testsShourya Shukla, Jan 18, 2020
  15. 1/3 t6025: modernize styleShourya Shukla, Jan 18, 2020
  16. 2/3 t6025: replace pipe with redirection operatorShourya Shukla, Jan 18, 2020
  17. 3/3 t6025: use helpers to replace test -f <path>Shourya Shukla, Jan 18, 2020
  18. 0/2 t025: amended changes after suggestions from the communityShourya Shukla, Jan 18, 2020
  19. 1/2 t6025: modernize styleShourya Shukla, Jan 18, 2020
  20. Junio C HamanoJan 21, 2020
  21. 2/2 t6025: use helpers to replace test -f <path>Shourya Shukla, Jan 18, 2020
  22. Junio C HamanoJan 21, 2020
  23. 3/3 t6025: use helpers to replace test -f <path>Shourya Shukla, Jan 17, 2020
  24. Johannes SchindelinJan 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.