Re: [PATCH v2 0/6] convert various shell functions in git-bisect to C

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 15, 2016, 17:53 UTC
Message-ID: <CAPig+cTV8Mum1b7XxUit4Kn5WBX2kukWvvjkhOCqxnFtcjfp0w@mail.gmail.com>
In-Reply-To: <20160615140026.10519-1-pranit.bauva@gmail.com>

On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva <pranit.bauva@gmail.com> wrote:

Show 9 quoted lines

> Changes wrt previous version:
>  * Use STRING_LIST_INIT_NODUP to avoid leaks in bisect_clean_state()
>  * Use test_path_is_missing in the patch 2/6
>  * drop file_size()
>  * move is_empty_file() method from builtin/am.c to wrapper.c
>  * use static for methods
>  * remove the variable status in bisect_reset() altogether and put the whole
>    thing inside the if block.
>  * one more method converted namely bisect_write().

As an aid to reviewers, in the future, please also include in the cover letter an interdiff between the previous and current version of the patch series. Thanks.