Re: [PATCH] Makefile: make NO_ICONV really mean "no iconv"

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 15, 2018, 06:30 UTC
Message-ID: <CAPig+cTSirqhayBDJFZhn2HL4EMr36GHuCOYAMaCeptqFtoR=w@mail.gmail.com>
In-Reply-To: <20180615042023.GA31294@sigill.intra.peff.net>

On Fri, Jun 15, 2018 at 12:20 AM Jeff King <peff@peff.net> wrote:

> We have OLD_ICONV, too, which should probably do nothing if NO_ICONV is
> set. I think that works OK. We end up setting -DOLD_ICONV on the command
> line, but that's only consider inside "#ifndef NO_ICONV" within the
> code.

Right, that was my conclusion, as well. Since it works as is, I'm not sure suppressing -DOLD_ICONV in Makefile is worth the extra patch noise. I can re-roll with that change too, if someone thinks it's worthwhile, though.