Re: Is NO_ICONV misnamed or is it broken?

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 17, 2018, 03:41 UTC
Message-ID: <CAPig+cRR8=vbafsjL_pnoq6ssxBkkoVo0OMd_i8P_a8ze7eLHg@mail.gmail.com>
In-Reply-To: <CAP8UFD2SJF_gbP-mdXoAH0t_OmLjRbPuVK5vZZjgs2N9eJz5KQ@mail.gmail.com>

On Sat, Jun 16, 2018 at 10:57 PM Christian Couder <christian.couder@gmail.com> wrote:

Show 14 quoted lines

> On Fri, Jun 15, 2018 at 12:47 AM, Mahmoud Al-Qudsi <mqudsi@neosmart.net> wrote:
> > ~> make NO_ICONV=1
> > # ommitted
> >     LINK git-credential-store
> > /usr/bin/ld: cannot find -liconv
> I think 597c9cc540 (Flatten tools/ directory to make build procedure
> simpler., 2005-09-07) which introduces NEEDS_LIBICONV is even older
> than the commit that introduced NO_ICONV (see above), so you might
> want to play with NEEDS_LIBICONV too and see if it works better for
> you.
>
> I CC'ed the people involved in related commits. Maybe they can give
> you a better answer. It might also help if you could tell us on which
> OS/Platform and perhaps for which purpose you want to compile Git.

For completeness, for those reading this thread, a patch fixing this issue has already been sent[1] to the list.

[1]: https://public-inbox.org/git/20180615022503.34111-1-sunshine@sunshineco.com/