Re: [PATCH] rebase -i: fix cases ignoring core.commentchar

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 16, 2013, 21:55 UTC
Message-ID: <CAPig+cTRc1-W7vJX52gb5S0ge4kZgKMBkHJjqWFRDgpuzTfM2g@mail.gmail.com>
In-Reply-To: <1376689447-78807-1-git-send-email-sunshine@sunshineco.com>

On Fri, Aug 16, 2013 at 5:44 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 11 quoted lines

> eff80a9fd990de36 (Allow custom "comment char", 2013-01-16) added general
> core.commentchar support but forgot to update git-rebase--interactive to
> respect it.  180bad3d10fe3a7f (rebase -i: respect core.commentchar,
> 2013-02-11) addressed this oversight but missed one instance of
> hard-coded '#' comment character in skip_unnecessary_picks(). Fix this.
>
> 9a46c25bdbf79744 (rebase: interactive: fix short SHA-1 collision,
> 2013-08-12) added another instance of hard-coded '#' comment character
> in transform_todo_ids().  Fix this, as well.
>
> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>

I forgot to mention that I wanted to add tests to t3404 for these bugs but couldn't figure out how to do it using the external behavior of rebase -i. I was able to verify the before and after behavior by adding temporary echo's to the code in order to observe the "internal" functioning.