Re: [PATCH] rebase -i: fix cases ignoring core.commentchar
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 18, 2013, 20:29 UTC
- Message-ID
- <7v38q6oi9a.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CAPig+cSFoKb+v5fEXnwr=94B6uo2b57vgHTRgtFMj25M+R9dUw@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
> One of the fixes in this patch addresses an oversight in > 180bad3d10fe3a7f (rebase -i: respect core.commentchar, 2013-02-11) > which is already in 'maint'. Should I split this patch in two so that > the one fix can be applied to 'maint'?
We are so close to 1.8.4 final and I do not think it makes much difference in practice, but if we were shooting for the ideal, yeah, as that part of the patch could make core.commentchar useful for rebase-i users who are still on 1.8.3.X maintenance track.