git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] teach format-patch to place other authors into in-body "From"

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jul 3, 2013, 07:21 UTC
Message-ID
<CAPig+cTMUrofUon85rZLw+NALQ5+agTRZW0UWYeBCutd_BPzwQ@mail.gmail.com>
In-Reply-To
<20130703070822.GB17730@sigill.intra.peff.net>
On Wed, Jul 3, 2013 at 3:08 AM, Jeff King <peff@peff.net> wrote:
Show 12 quoted lines
> Format-patch generates emails with the "From" address set to
> the author of each patch. If you are going to send the
> emails, however, you would want to replace the author
> identity with yours (if they are not the same), and bump the
> author identity to an in-body header.
>
> Normally this is handled by git-send-email, which does the
> transformation before sending out the emails. However, some
> workflows may not use send-email (e.g., imap-send, or a
> custom script which feeds the mbox to a non-git MUA). They
> could each implement this feature themselves, but getting it
> right is non-trivial (one most canonicalize the identities
s/most/must/
Show 12 quoted lines
> by reversing any RFC2047 encoding or RFC822 quoting of the
> headers, which has caused many bugs in send-email over the
> years).
>
> This patch takes a different approach: it teaches
> format-patch a "--from" option which handles the ident
> check and in-body header while it is writing out the email.
> It's much simpler to do at this level (because we haven't
> done any quoting yet), and any workflow based on
> format-patch can easily turn it on.
>
> Signed-off-by: Jeff King <peff@peff.net>
Previous: Jeff KingNext: Junio C Hamano
Message 4 of 6 in “format-patch handling in-body From headers”
  1. 0/2 format-patch handling in-body From headersJeff King, Jul 3, 2013
  2. 1/2 pretty.c: drop const-ness from pretty_print_contextJeff King, Jul 3, 2013
  3. 2/2 teach format-patch to place other authors into in-body "From"Jeff King, Jul 3, 2013
  4. Eric SunshineJul 3, 2013
  5. Junio C HamanoJul 3, 2013
  6. Jeff KingJul 3, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.