From: Eric Sunshine Date: Wed, 03 Jul 2013 07:21:28 GMT Subject: Re: [PATCH 2/2] teach format-patch to place other authors into in-body "From" Message-ID: In-Reply-To: <20130703070822.GB17730@sigill.intra.peff.net> On Wed, Jul 3, 2013 at 3:08 AM, Jeff King wrote: > Format-patch generates emails with the "From" address set to > the author of each patch. If you are going to send the > emails, however, you would want to replace the author > identity with yours (if they are not the same), and bump the > author identity to an in-body header. > > Normally this is handled by git-send-email, which does the > transformation before sending out the emails. However, some > workflows may not use send-email (e.g., imap-send, or a > custom script which feeds the mbox to a non-git MUA). They > could each implement this feature themselves, but getting it > right is non-trivial (one most canonicalize the identities s/most/must/ > by reversing any RFC2047 encoding or RFC822 quoting of the > headers, which has caused many bugs in send-email over the > years). > > This patch takes a different approach: it teaches > format-patch a "--from" option which handles the ident > check and in-body header while it is writing out the email. > It's much simpler to do at this level (because we haven't > done any quoting yet), and any workflow based on > format-patch can easily turn it on. > > Signed-off-by: Jeff King