Re: [PATCH 2/3] t5516: use double quotes for tests with variables
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jun 2, 2025, 16:59 UTC
- Message-ID
- <CAPig+cTMDcvwfzq7Pqn+MF7r1x7qZq2k=8pAV3bio0pcnuh4eA@mail.gmail.com>
- In-Reply-To
- <20250602-6769-address-test-failures-in-the-next-branch-caused-by-batched-reference-updates-v1-2-903d1db3f10e@gmail.com>
On Mon, Jun 2, 2025 at 5:58 AM Karthik Nayak <karthik.188@gmail.com> wrote:
Show 9 quoted lines
> Since expressions don't expand within single quotes, change test > descriptions containing variables to use double quotes. > > Signed-off-by: Karthik Nayak <karthik.188@gmail.com> > --- > diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh > @@ -1421,7 +1421,7 @@ test_expect_success 'peeled advertisements are not considered ref tips' ' > -test_expect_success 'pushing a specific ref applies remote.$name.push as refmap' ' > +test_expect_success "pushing a specific ref applies remote.$name.push as refmap" '
If I'm understanding correctly, I think this and the other changes in this patch are incorrect. There is no `name` variable in this script. Rather, these "$name" instances are merely illustrative, acting as placeholders for the person reading the test title.