Re: [PATCH 1/3] refs/files: skip updates with errors in batched updates

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jun 2, 2025, 17:13 UTC
Message-ID: <CAOLa=ZTP0i5q9Qw4g_ei+kSLyaRAMEoHf=PnPFbr7pRqgnyXAw@mail.gmail.com>
In-Reply-To: <xmqqcybmuqrj.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>>> Curious -- we do have tests, so why don't any of them hit this issue?
>>>
>>
>> We don't hit this edge case in any of our tests I presume. This
>> basically requires a deletion request with an expected old OID, however
>> the reference should be non-existent.
>
> I read Patrick's remart not as a question but as a rhetoric
> suggestion to make sure we have test coverage ;-)

Ah! Okay, all is good then, since my patch does add a test for this now.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.