git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Jun 2018, #04; Fri, 15)

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jun 15, 2018, 20:49 UTC
Message-ID
<CAPig+cTFhkKiMjjOTaFCuiyQC96oH8V-d1adFmyeHfDsB5gr7A@mail.gmail.com>
In-Reply-To
<xmqqd0wrztgh.fsf@gitster-ct.c.googlers.com>
On Fri, Jun 15, 2018 at 4:27 PM Junio C Hamano <gitster@pobox.com> wrote:
> * es/make-no-iconv (2018-06-15) 1 commit
>  - Makefile: make NO_ICONV really mean "no iconv"
>
>  "make NO_ICONV=NoThanks" did not override NEEDS_LIBICONV
Nit: The double-negative is a bit confusing. s/NoThanks/YesPlease/
would be easier to grok and would be more idiomatic (taking
config.mak.uname into account).
>  (i.e. linkage of -lintl, -liconv, etc. that are platform-specific
>  tweaks), which has been corrected.
Previous: Junio C Hamano
Message 2 of 2 in “What's cooking in git.git (Jun 2018, #04; Fri, 15)”
  1. Junio C HamanoJun 15, 2018
  2. Eric SunshineJun 15, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.