From: Eric Sunshine <sunshine@sunshineco.com>
Date: Fri, 15 Jun 2018 20:49:58 GMT
Subject: Re: What's cooking in git.git (Jun 2018, #04; Fri, 15)
Message-ID: <CAPig+cTFhkKiMjjOTaFCuiyQC96oH8V-d1adFmyeHfDsB5gr7A@mail.gmail.com>
In-Reply-To: <xmqqd0wrztgh.fsf@gitster-ct.c.googlers.com>

On Fri, Jun 15, 2018 at 4:27 PM Junio C Hamano <gitster@pobox.com> wrote:
> * es/make-no-iconv (2018-06-15) 1 commit
>  - Makefile: make NO_ICONV really mean "no iconv"
>
>  "make NO_ICONV=NoThanks" did not override NEEDS_LIBICONV

Nit: The double-negative is a bit confusing. s/NoThanks/YesPlease/
would be easier to grok and would be more idiomatic (taking
config.mak.uname into account).

>  (i.e. linkage of -lintl, -liconv, etc. that are platform-specific
>  tweaks), which has been corrected.