Re: [PATCH v3 13/22] t5317: use ! grep to check for no matching lines

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Nov 23, 2019, 06:21 UTC
Message-ID: <CAPig+cTE_cYQi=Ys5tKYbs6bRXf9moNqO6zo1M_hn6w9HfL-bQ@mail.gmail.com>
In-Reply-To: <85c2f8ca2704e54c2d0e6e65822a04d21e383f6a.1574449072.git.liu.denton@gmail.com>

On Fri, Nov 22, 2019 at 2:00 PM Denton Liu <liu.denton@gmail.com> wrote:

Show 7 quoted lines

> [...]
> While at it, drop unnecessary invocations of 'awk' and 'sort' in each
> affected test since those commands do not influence the outcome. It's
> not clear why that extra work was being done in the first place, and the
> code's history doesn't shed any light on the matter since these tests
> were simply born this way[1], doing all the unnecessary work for no
> reason, probably due to copy/paste programming...

Taking this wording literally from my review comment[1] is (again) fine, but I ended the fragment intentionally with "..." with the expectation that you would fill in the remainder, not expecting you to copy/paste the fragment blindly. Without the remainder -- the part which is supposed to follow the "..." -- the reader if left hanging.

[1]: https://lore.kernel.org/git/CAPig+cQviTjwLSZ+QkC62B58mq6z3yDA-XhPVJQYRq0inEo9nA@mail.gmail.com/