Re: fatal from submodule status --recursive when used with grep -q

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 19, 2024, 19:40 UTC
Message-ID: <CAPig+cTDFcJiig7=Sf5vxsgzc8_ax5t7Vqy+-_x8OK_U5U6Qnw@mail.gmail.com>
In-Reply-To: <xmqqsetv795s.fsf@gitster.g>

On Thu, Sep 19, 2024 at 3:10 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Matt Liberty <mliberty@precisioninno.com> writes:
> > Yes and also to have a 0 exit code.  No error occurred from my perspective.
>
> I am sympathetic to the line of reasoning, but I wouldn't go that
> far.
>
> Running "yes | less" and killing it with 'q' saying "ok I've seen
> enough", and running "yes" and killing it with '^C' saying "ok I've
> seen enough" are pretty much the same from the end-user perspective.
> You told the command to go away, and the command complied.  But I
> haven't seen anybody complaining if they see a "Killed" message or
> "echo $?" immediately after it says 130 for the latter.

Regarding the exit code, it's not even clear how that factors into this discussion considering that, in the presented example, git-submodule is upstream of a pipe, thus its exit code is lost anyhow.