Re: fatal from submodule status --recursive when used with grep -q

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Sep 18, 2024, 10:05 UTC
Message-ID: <7b4ce2fc-3763-4881-8459-e0c1f2cbc69d@gmail.com>
In-Reply-To: <CAKDm0rNaHbzoiPg=DeuCoxzooNAsxw2BJfc0wg7fC_-=o9uJ7w@mail.gmail.com>

Hi Matt

On 16/09/2024 16:08, Matt Liberty wrote:

Show 9 quoted lines

> 
> If I try to grep the output I get a fatal error:
> 
> % git submodule status --recursive | grep -q "^+"
> fatal: failed to recurse into submodule 'tools/OpenROAD'
> 
> I didn't expect any output but did want the return status (0).  I'm
> guessing git is unhappy that grep -q exits on the first occurrence of
> the pattern.  I don't feel fatal is appropriate here.

I assume git is dying with SIGPIPE. As the only purpose of "git submodule status" is to write the status information to stdout that sounds reasonable. If you want to collect the exit status you need to consume the whole output so that the command runs to completion.

Best Wishes

Phillip

Show 6 quoted lines

> I can work around this by writing to a tmpfile but would like to see
> this addressed.
> 
> Thanks!
> Matt
>