Re: [PATCH] CodingGuidelines: document which output goes to stdout vs. stderr

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Dec 1, 2021, 21:57 UTC
Message-ID: <CAPig+cTAg7CwYZBEMVyub05GrGkHjLSuZ_YJ-PdAQ7M_C3aMqg@mail.gmail.com>
In-Reply-To: <xmqqtufsypmu.fsf@gitster.g>

On Wed, Dec 1, 2021 at 4:36 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

> Eric Sunshine <sunshine@sunshineco.com> writes:
> > However, I can certainly change these to say "Git command" if you
> > think it would make the intent clearer, and can update the final point
> > to say:
> >
> >     Error messages from Git commands should always
> >     be sent to the stderr stream.
>
> In an earlier round, I think there was a version without "should" in
> there, but I am sure we have bugs that do not follow the guideline.
> The proposed phrasing sounds good to me.

Yes, the addition of "should" was intentional, though not for any concrete reason (it just felt appropriate). I don't feel strongly either way.