Re: [PATCH 1/2] bisect--helper: `is_expected_rev` shell function in C

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 9, 2016, 21:39 UTC
Message-ID: <CAPig+cTAQAnTwQ7=Akw7N6FJS6jKc7hmZFVW=03b9NVD9+22ew@mail.gmail.com>
In-Reply-To: <CAPig+cRC_y9MBSsrLEs0OxL4=FMfU-=ACwhESUiECrWrDNvaCw@mail.gmail.com>

On Thu, Jun 9, 2016 at 5:33 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 8 quoted lines

> On Wed, Jun 8, 2016 at 11:24 AM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
>> +       strbuf_trim(&actual_hex);
>> +       return !strcmp(actual_hex.buf, expected_hex);
>
> Thus, it only ever gets to this point if the file exists but is empty,
> which is very unlikely to match 'expected_hex'. I could understand it
> if you checked the result of strbuf_read_file() with <0 or even <=0,
> but the current code doesn't make sense to me.

By the way, this is also leaking strbuf 'actual_hex'.