git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Nov 17, 2015, 17:44 UTC
Message-ID
<CAPig+cT2aBrL6Qh3W3d-ODjj7S0GORkTZMyQ6PBfHCLVqeKBvQ@mail.gmail.com>
In-Reply-To
<564AF48C.9040406@diamand.org>
On Tue, Nov 17, 2015 at 4:34 AM, Luke Diamand <luke@diamand.org> wrote:
Show 19 quoted lines
>>> While implementing it I thought more about it. P4D is only
>>> supported on platforms that support the date function. That means
>>> these tests will only run on platforms that support the date
>>> function. Consequently I wondered if this would justify the
>>> slightly more complicated code. However, if you think this change
>>> would help the patch to get accepted then I will add it.
>>
>> I don't feel strongly about it, and it's not my call anyhow. Opinions
>> of Junio, Peff (as interim maintainer), and Luke weigh much more
>> heavily than my own. Punting on dynamic detection of "date +%s" may be
>> perfectly acceptable with the attitude that it can be implemented
>> later if someone runs across a case where it's actually needed.
>
> Which other platforms are we talking about here?
>
> https://www.perforce.com/downloads/helix
>
> From there, you can get Solaris10, HP-UX, AIX and various flavours of BSD.
> Solaris supports "date +%s".

The question about "date +%s" portability arose with a suggestion to employ it in git-filter-branch[1]. Apparently, the concern about Solaris was raised in response to a Stack Overflow question[2] which claimed that +%s was not supported by that OS. Unfortunately, however, [2] did not indicate to which (older?) versions of Solaris that shortcoming applied. If Solaris 10 does support +%s, and the Perforce product is only available for Solaris 10, then perhaps concern about +%s a non-issue(?).

[1]: http://git.661346.n2.nabble.com/FEATURE-REQUEST-Filter-branch-extend-progress-with-a-simple-estimated-time-remaning-td7638200.html#a7638504 [2]: http://stackoverflow.com/questions/2445198/get-seconds-since-epoch-in-any-posix-compliant-shell

Previous: Luke DiamandNext: Luke Diamand
Message 12 of 19 in “Add Travis CI support”
  1. 0/6 Add Travis CI supportlarsxschneider@gmail.com, Nov 15, 2015
  2. 1/6 implement test_might_fail using a refactored test_must_faillarsxschneider@gmail.com, Nov 15, 2015
  3. 2/6 add "ok=sigpipe" to test_must_fail and use it to fix flaky testslarsxschneider@gmail.com, Nov 15, 2015
  4. 3/6 git-p4: retry kill/cleanup operations in tests with timeoutlarsxschneider@gmail.com, Nov 15, 2015
  5. Luke DiamandNov 16, 2015
  6. Lars SchneiderNov 17, 2015
  7. Luke DiamandNov 17, 2015
  8. Eric SunshineNov 16, 2015
  9. Lars SchneiderNov 17, 2015
  10. Eric SunshineNov 17, 2015
  11. Luke DiamandNov 17, 2015
  12. Eric SunshineNov 17, 2015
  13. Luke DiamandNov 17, 2015
  14. 4/6 git-p4: add p4d timeout in testslarsxschneider@gmail.com, Nov 15, 2015
  15. Luke DiamandNov 16, 2015
  16. 5/6 git-p4: add trap to kill p4d on test exitlarsxschneider@gmail.com, Nov 15, 2015
  17. Luke DiamandNov 16, 2015
  18. Lars SchneiderNov 17, 2015
  19. 6/6 Add Travis CI supportlarsxschneider@gmail.com, Nov 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.