git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout

From
Luke Diamand <luke@diamand.org>
Date
Nov 17, 2015, 09:38 UTC
Message-ID
<564AF59F.2070601@diamand.org>
In-Reply-To
<90549E9A-205A-4848-B794-23E44F325F1E@gmail.com>
On 17/11/15 08:22, Lars Schneider wrote:
Show 18 quoted lines
>
> On 16 Nov 2015, at 09:36, Luke Diamand <luke@diamand.org> wrote:
>
>> On 15/11/15 13:08, larsxschneider@gmail.com wrote:
>>> From: Lars Schneider <larsxschneider@gmail.com>
>>>
>>> In rare cases kill/cleanup operations in tests fail. Retry these
>>> operations with a timeout to make the test less flaky.
>>
>> Should there be a sleep in that retry_until_success loop so that it doesn't spin sending signals to p4d?
> Agreed. I will add a sleep in the next roll!
>
>
>>
>> Do we need to worry about the time offset being updated (e.g. NTP) while this is running?
> Interesting question! I would consider this an edge case but I can see how it could happen.
> Do you see a way to handle that in an easy way?
>

You want to somehow call clock_gettime(CLOCK_MONOTONIC). That's not in python until 3.3. Writing a C program seems like overkill but could be a solution if this becomes a problem.

Previous: Lars SchneiderNext: Eric Sunshine
Message 7 of 19 in “Add Travis CI support”
  1. 0/6 Add Travis CI supportlarsxschneider@gmail.com, Nov 15, 2015
  2. 1/6 implement test_might_fail using a refactored test_must_faillarsxschneider@gmail.com, Nov 15, 2015
  3. 2/6 add "ok=sigpipe" to test_must_fail and use it to fix flaky testslarsxschneider@gmail.com, Nov 15, 2015
  4. 3/6 git-p4: retry kill/cleanup operations in tests with timeoutlarsxschneider@gmail.com, Nov 15, 2015
  5. Luke DiamandNov 16, 2015
  6. Lars SchneiderNov 17, 2015
  7. Luke DiamandNov 17, 2015
  8. Eric SunshineNov 16, 2015
  9. Lars SchneiderNov 17, 2015
  10. Eric SunshineNov 17, 2015
  11. Luke DiamandNov 17, 2015
  12. Eric SunshineNov 17, 2015
  13. Luke DiamandNov 17, 2015
  14. 4/6 git-p4: add p4d timeout in testslarsxschneider@gmail.com, Nov 15, 2015
  15. Luke DiamandNov 16, 2015
  16. 5/6 git-p4: add trap to kill p4d on test exitlarsxschneider@gmail.com, Nov 15, 2015
  17. Luke DiamandNov 16, 2015
  18. Lars SchneiderNov 17, 2015
  19. 6/6 Add Travis CI supportlarsxschneider@gmail.com, Nov 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.