Re: [PATCH] config.mak.dev: enable -Wpedantic in clang
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Nov 27, 2018, 10:53 UTC
- Message-ID
- <CAPig+cT1ruGsd-7yXV3Oxs2_9zOh-d4HgZiQ-OVZzHc1buo4FQ@mail.gmail.com>
- In-Reply-To
- <20181127100557.53891-1-carenas@gmail.com>
On Tue, Nov 27, 2018 at 5:06 AM Carlo Marcelo Arenas Belón <carenas@gmail.com> wrote:
> [...] > -Wpedantic is only enabled for clang 10 or higher (only available in macOS > with latest Xcode) but this restriction should be relaxed further as more > environments are tested
We know from [1] that the clang version number "10" is an Apple fiction/invention. Perhaps this commit message can be worded a bit more carefully to avoid confusing readers who are not clued in to that fact.
[1]: https://public-inbox.org/git/CAPig+cRQXQ_DowS2Dsc1x3TAGJjnWig7P4eYS4kQ+C2piAdSWA@mail.gmail.com/
Show 5 quoted lines
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com> > --- > +ifneq ($(filter clang10,$(COMPILER_FEATURES)),) > +CFLAGS += -Wpedantic > +endif
Should this condition be tightened to match only for OSX since there is no such clang version number in the rest world outside of Apple?