From: Eric Sunshine Date: Tue, 27 Nov 2018 10:53:43 GMT Subject: Re: [PATCH] config.mak.dev: enable -Wpedantic in clang Message-ID: In-Reply-To: <20181127100557.53891-1-carenas@gmail.com> On Tue, Nov 27, 2018 at 5:06 AM Carlo Marcelo Arenas Belón wrote: > [...] > -Wpedantic is only enabled for clang 10 or higher (only available in macOS > with latest Xcode) but this restriction should be relaxed further as more > environments are tested We know from [1] that the clang version number "10" is an Apple fiction/invention. Perhaps this commit message can be worded a bit more carefully to avoid confusing readers who are not clued in to that fact. [1]: https://public-inbox.org/git/CAPig+cRQXQ_DowS2Dsc1x3TAGJjnWig7P4eYS4kQ+C2piAdSWA@mail.gmail.com/ > Signed-off-by: Carlo Marcelo Arenas Belón > --- > +ifneq ($(filter clang10,$(COMPILER_FEATURES)),) > +CFLAGS += -Wpedantic > +endif Should this condition be tightened to match only for OSX since there is no such clang version number in the rest world outside of Apple?