git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1 1/2] perf/run: add --subsection option

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Apr 8, 2018, 09:44 UTC
Message-ID
<CAPig+cT=kn0hujoeLxkYTv1wZA93QxP-CQPepmzs1SDq1QJWEw@mail.gmail.com>
In-Reply-To
<20180408093513.17769-2-chriscool@tuxfamily.org>

On Sun, Apr 8, 2018 at 5:35 AM, Christian Couder <christian.couder@gmail.com> wrote:

Show 8 quoted lines
> This new option makes it possible to run perf tests as defined
> in only one subsection of a config file.
>
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
> diff --git a/t/perf/run b/t/perf/run
> @@ -1,21 +1,34 @@
> +while [ $# -gt 0 ]; do

I was going to ask if you meant to use 'test' here rather than '[', however, I see that this script already has a mix of the two, so...

Likewise, scripts in Git usually omit the semicolon and place 'do' on its own line, however, again I see that this script has a mix of the two styles, so...

Previous: Christian CouderNext: Christian Couder
Message 3 of 4 in “t/perf: bisect performance regressions”
  1. 0/2 t/perf: bisect performance regressionsChristian Couder, Apr 8, 2018
  2. 1/2 perf/run: add --subsection optionChristian Couder, Apr 8, 2018
  3. Eric SunshineApr 8, 2018
  4. 2/2 t/perf: add scripts to bisect performance regressionsChristian Couder, Apr 8, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.