From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 08 Apr 2018 09:44:58 GMT
Subject: Re: [PATCH v1 1/2] perf/run: add --subsection option
Message-ID: <CAPig+cT=kn0hujoeLxkYTv1wZA93QxP-CQPepmzs1SDq1QJWEw@mail.gmail.com>
In-Reply-To: <20180408093513.17769-2-chriscool@tuxfamily.org>

On Sun, Apr 8, 2018 at 5:35 AM, Christian Couder
<christian.couder@gmail.com> wrote:
> This new option makes it possible to run perf tests as defined
> in only one subsection of a config file.
>
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
> diff --git a/t/perf/run b/t/perf/run
> @@ -1,21 +1,34 @@
> +while [ $# -gt 0 ]; do

I was going to ask if you meant to use 'test' here rather than '[',
however, I see that this script already has a mix of the two, so...

Likewise, scripts in Git usually omit the semicolon and place 'do' on
its own line, however, again I see that this script has a mix of the
two styles, so...