git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v11 03/13] ref-filter: introduce ref_formatting_state

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Aug 17, 2015, 05:15 UTC
Message-ID
<CAPig+cSwZaNbUDG+46LfAGB4GjDm5sbkroO_mR+hvCcVHq00cg@mail.gmail.com>
In-Reply-To
<CAPig+cRmFCpbJVzrAYqPRcJVKD7czfi7Mni_BzaoB2RkJnFJMg@mail.gmail.com>
On Sun, Aug 16, 2015 at 7:31 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 13 quoted lines
> On Sat, Aug 15, 2015 at 2:00 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
>> +struct ref_formatting_state {
>> +       struct strbuf output;
>> +       struct ref_formatting_state *prev;
>
> Upon initial read-through of this patch, I found the name 'prev'
> confusing since it seems you sometimes treat this as a linked-list
> and, for a linked-list, this member is customarily named 'next'.
> However, you also sometimes treat it as a stack, in which case 'prev'
> makes a certain amount of sense semantically, although so does 'next'.
> I'd probably have named it 'next', however, attr.c:struct attr_stack
> names its member 'prev', so there is some precedence for the current
> choice.
s/precedence/precedent/
Previous: Eric SunshineNext: Karthik Nayak
Message 3 of 4 in “ref-filter: introduce ref_formatting_state”
  1. 03/13 ref-filter: introduce ref_formatting_stateKarthik Nayak, Aug 15, 2015
  2. Eric SunshineAug 16, 2015
  3. Eric SunshineAug 17, 2015
  4. Karthik NayakAug 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.