From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 17 Aug 2015 05:15:20 GMT
Subject: Re: [PATCH v11 03/13] ref-filter: introduce ref_formatting_state
Message-ID: <CAPig+cSwZaNbUDG+46LfAGB4GjDm5sbkroO_mR+hvCcVHq00cg@mail.gmail.com>
In-Reply-To: <CAPig+cRmFCpbJVzrAYqPRcJVKD7czfi7Mni_BzaoB2RkJnFJMg@mail.gmail.com>

On Sun, Aug 16, 2015 at 7:31 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Sat, Aug 15, 2015 at 2:00 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
>> +struct ref_formatting_state {
>> +       struct strbuf output;
>> +       struct ref_formatting_state *prev;
>
> Upon initial read-through of this patch, I found the name 'prev'
> confusing since it seems you sometimes treat this as a linked-list
> and, for a linked-list, this member is customarily named 'next'.
> However, you also sometimes treat it as a stack, in which case 'prev'
> makes a certain amount of sense semantically, although so does 'next'.
> I'd probably have named it 'next', however, attr.c:struct attr_stack
> names its member 'prev', so there is some precedence for the current
> choice.

s/precedence/precedent/