git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] configure.ac: check tv_nsec field in struct stat

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jan 8, 2015, 05:41 UTC
Message-ID
<CAPig+cSwBZuYAp97nLBLcdCkTrcbCfwZ+xKe0JAEt_ekk3EFRA@mail.gmail.com>
In-Reply-To
<CAD_8n+RkCWzz0VSPb+3XkR-qbms1csGBbFRJtc-HwMp823QdCQ@mail.gmail.com>
On Wed, Jan 7, 2015 at 5:19 PM, Reuben Hawkins <reubenhwk@gmail.com> wrote:
Show 19 quoted lines
> On Wed, Jan 7, 2015 at 1:19 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins <reubenhwk@gmail.com> wrote:
>>> This check will automatically set the correct NO_NSEC setting.
>>
>> This commit message neglects to mention the important point that
>> you're also now setting USE_ST_TIMESPEC when detected. You might
>> revise the message like this:
>>
>>     Detect 'tv_nsec' field in 'struct stat' and set Makefile variable
>>     NO_NSEC appropriately.
>>
>>     A side-effect of the above detection is that we also determine
>>     whether 'stat.st_mtimespec' is available, so, as a bonus, set the
>>     Makefile variable USE_ST_TIMESPEC, as well.
>
> I see you're single quoted 'tv_nsec' and 'struct stat'.  Should I also
> use single quotes in the first line of the commit msg like this...
>
> configure.ac: check 'tv_nsec' field in 'struct stat'

Quoting them was just my personal taste, however, consistency of formatting between subject and the body of the message would be nice. Use whatever seems correct to you.

Previous: Reuben HawkinsNext: Reuben Hawkins
Message 14 of 22 in “configure.ac: check tv_nsec field in struct stat”
  1. 1/3 configure.ac: check tv_nsec field in struct statReuben Hawkins, Dec 21, 2014
  2. 2/3 configure.ac,trace.c: check for CLOCK_MONOTONICReuben Hawkins, Dec 21, 2014
  3. Eric SunshineDec 21, 2014
  4. brian m. carlsonDec 22, 2014
  5. Reuben HawkinsDec 22, 2014
  6. 3/3 configure.ac,imap-send.c: check HMAC_CTX_cleanupReuben Hawkins, Dec 21, 2014
  7. Eric SunshineDec 21, 2014
  8. v2 patches for fixes on RHEL3Reuben Hawkins, Jan 7, 2015
  9. 1/3 configure.ac: check tv_nsec field in struct statReuben Hawkins, Jan 7, 2015
  10. Eric SunshineJan 7, 2015
  11. Reuben HawkinsJan 7, 2015
  12. Eric SunshineJan 7, 2015
  13. Reuben HawkinsJan 7, 2015
  14. Eric SunshineJan 8, 2015
  15. 2/3 configure.ac: check for clock_gettime and CLOCK_MONOTONICReuben Hawkins, Jan 7, 2015
  16. Eric SunshineJan 7, 2015
  17. Reuben HawkinsJan 7, 2015
  18. Eric SunshineJan 8, 2015
  19. 3/3 configure.ac: check for HMAC_CTX_cleanupReuben Hawkins, Jan 7, 2015
  20. Eric SunshineJan 7, 2015
  21. Eric SunshineDec 21, 2014
  22. Eric SunshineDec 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.