From: Eric Sunshine Date: Thu, 08 Jan 2015 05:41:57 GMT Subject: Re: [PATCH 1/3] configure.ac: check tv_nsec field in struct stat Message-ID: In-Reply-To: On Wed, Jan 7, 2015 at 5:19 PM, Reuben Hawkins wrote: > On Wed, Jan 7, 2015 at 1:19 PM, Eric Sunshine wrote: >> On Wed, Jan 7, 2015 at 3:23 PM, Reuben Hawkins wrote: >>> This check will automatically set the correct NO_NSEC setting. >> >> This commit message neglects to mention the important point that >> you're also now setting USE_ST_TIMESPEC when detected. You might >> revise the message like this: >> >> Detect 'tv_nsec' field in 'struct stat' and set Makefile variable >> NO_NSEC appropriately. >> >> A side-effect of the above detection is that we also determine >> whether 'stat.st_mtimespec' is available, so, as a bonus, set the >> Makefile variable USE_ST_TIMESPEC, as well. > > I see you're single quoted 'tv_nsec' and 'struct stat'. Should I also > use single quotes in the first line of the commit msg like this... > > configure.ac: check 'tv_nsec' field in 'struct stat' Quoting them was just my personal taste, however, consistency of formatting between subject and the body of the message would be nice. Use whatever seems correct to you.