Re: [PATCH 2/2] refs: warn on non-pseudoref looking .git/<file> refs

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Dec 10, 2020, 20:47 UTC
Message-ID: <CAPig+cSph9EcnGDUBjWsvR3yfbydK=mOMPmCEas=YC6bUJS=zA@mail.gmail.com>
In-Reply-To: <87sg8dwglk.fsf@evledraar.gmail.com>

On Thu, Dec 10, 2020 at 3:29 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 18 quoted lines

> On Thu, Dec 10 2020, Eric Sunshine wrote:
> > On Thu, Dec 10, 2020 at 7:55 AM Ævar Arnfjörð Bjarmason
> > <avarab@gmail.com> wrote:
> >> +       GIT_TEST_GETTEXT_POISON=false grep "like a pseudoref" err &&
> >
> > What is the purpose of assigning GIT_TEST_GETTEXT_POISON here?
>
> Since 6cdccfce1e0 (i18n: make GETTEXT_POISON a runtime option,
> 2018-11-08) we haven't needed to use the C_LOCALE_OUTPUT prerequisite
> for any new code, since we can just turn the poisoning off.
>
> I think we should just slowly refactor things away from that
> prerequisite and test_i18ngrep, which were only needed because it used
> to be a compile-time switch, but I haven't gotter around to that
> refactoring.
>
> In liue of that I think it makes more sense to always run the full test
> if possible, no matter what the GIT_TEST_* mode is.

I must be missing something. I've looked at 6cdccfce1e0 but I still don't see how or why `GIT_TEST_GETTEXT_POISON=false` could affect the simple `grep` invocation being done by this test. I could understand if GIT_TEST_GETTEXT_POISON was applied to the invocation of a Git command, but that's not the case here.

(I also notice that 6cdccfce1e0 only checks whether GIT_TEST_GETTEXT_POISON is empty or not -- and the changes in 6cdccfce1e0 set GIT_TEST_GETTEXT_POISON to an empty value rather than to "false", so I find myself doubly confused by this application of GIT_TEST_GETTEXT_POISON to `grep`.)