git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] refs: move is_pseudoref_syntax() earlier in the file

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Dec 10, 2020, 12:53 UTC
Message-ID
<20201210125321.19456-1-avarab@gmail.com>

This move is needed by a subsequent change to the expand_ref() function, which will make use of these functions.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 refs.c | 38 +++++++++++++++++++-------------------
 1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/refs.c b/refs.c
index 392f0bbf68b..3ec5dcba0be 100644
--- a/refs.c
+++ b/refs.c
@@ -630,6 +630,25 @@ int repo_dwim_ref(struct repository *r, const char *str, int len,
 	return refs_found;
 }
 
+static int is_pseudoref_syntax(const char *refname)
+{
+	const char *c;
+
+	for (c = refname; *c; c++) {
+		if (!isupper(*c) && *c != '-' && *c != '_')
+			return 0;
+	}
+
+	return 1;
+}
+
+static int is_main_pseudoref_syntax(const char *refname)
+{
+	return skip_prefix(refname, "main-worktree/", &refname) &&
+		*refname &&
+		is_pseudoref_syntax(refname);
+}
+
 int expand_ref(struct repository *repo, const char *str, int len,
 	       struct object_id *oid, char **ref)
 {
@@ -716,25 +735,6 @@ static int is_per_worktree_ref(const char *refname)
 	       starts_with(refname, "refs/rewritten/");
 }
 
-static int is_pseudoref_syntax(const char *refname)
-{
-	const char *c;
-
-	for (c = refname; *c; c++) {
-		if (!isupper(*c) && *c != '-' && *c != '_')
-			return 0;
-	}
-
-	return 1;
-}
-
-static int is_main_pseudoref_syntax(const char *refname)
-{
-	return skip_prefix(refname, "main-worktree/", &refname) &&
-		*refname &&
-		is_pseudoref_syntax(refname);
-}
-
 static int is_other_pseudoref_syntax(const char *refname)
 {
 	if (!skip_prefix(refname, "worktrees/", &refname))
-- 
2.29.2.222.g5d2a92d10f8
Next: Ævar Arnfjörð Bjarmason
Message 1 of 12 in “refs: move is_pseudoref_syntax() earlier in the file”
  1. 1/2 refs: move is_pseudoref_syntax() earlier in the fileÆvar Arnfjörð Bjarmason, Dec 10, 2020
  2. 2/2 refs: warn on non-pseudoref looking .git/<file> refsÆvar Arnfjörð Bjarmason, Dec 10, 2020
  3. Eric SunshineDec 10, 2020
  4. Ævar Arnfjörð BjarmasonDec 10, 2020
  5. Eric SunshineDec 10, 2020
  6. Ævar Arnfjörð BjarmasonDec 10, 2020
  7. 2/2 refs: warn on non-pseudoref looking .git/<file> refsÆvar Arnfjörð Bjarmason, Dec 14, 2020
  8. Eric SunshineDec 14, 2020
  9. Junio C HamanoDec 14, 2020
  10. Ævar Arnfjörð BjarmasonDec 15, 2020
  11. 1/2 refs: move is_pseudoref_syntax() earlier in the fileÆvar Arnfjörð Bjarmason, Dec 14, 2020
  12. 0/2 warn on non-pseudoref looking .git/<file> refsÆvar Arnfjörð Bjarmason, Dec 14, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.