Re: [PATCH v2] worktree: add -z option for list subcommand
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- May 11, 2023, 04:11 UTC
- Message-ID
- <CAPig+cSmwQGSmm=drVodNzL0OmfG0EFawev=PjzJ4TbKgJhHsg@mail.gmail.com>
- In-Reply-To
- <xmqqk0c926zf.fsf@gitster.g>
On Thu, Mar 31, 2022 at 4:37 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 20 quoted lines
> "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes: > > Add a -z option to be used in conjunction with --porcelain that gives > > NUL-terminated output. As 'worktree list --porcelain' does not quote > > worktree paths this enables it to handle worktree paths that contain > > newlines. > > > > Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk> > > --- > > worktree: add -z option for list subcommand > > > > Thanks to Eric, Jean-Noël and Junio for their comments on V1. I've > > reworded the docs and option help and tweaked the tests as suggested by > > Eric, fixed the error messages as suggested by Eric/Jean-Noël and > > changed the implementation to use write_name_quoted() as suggested by > > Junio. I've punted doing anything about quoting the output without -z > > for now, I'll fix that with and without --porcelain in another series. > > Thanks for an update. Will queue. I think this iteration is good > to merge to 'next', but let's wait for a few days to see what others > think.
Agreed. I think this version addresses my review comments on earlier rounds and seems to be in good shape.
(Sorry for the late response.)